Skip to content

refactor(cli): decompose render phases#2172

Open
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-centralize-process-lifecyclefrom
07-10-refactor-cli-decompose-render-phases
Open

refactor(cli): decompose render phases#2172
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-centralize-process-lifecyclefrom
07-10-refactor-cli-decompose-render-phases

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Decompose the CLI render command into explicit plan, execute, and present phases.

Why

The monolithic handler mixed validation, environment mutation, rendering, progress, cleanup, and output formatting, making lifecycle bugs and batch JSON corruption easy to introduce.

How

Build an immutable RenderPlan, keep environment changes declarative, execute through one lifecycle boundary, and make presentation emit exactly one final JSON document in batch mode.

Test plan

  • Render-plan and presentation tests; complete CLI suite
  • CLI build, typecheck, and stack-wide validation gates

This was referenced Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from e3bcd5a to c4d49b9 Compare July 12, 2026 04:58
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 807e86c to 02cb4e2 Compare July 12, 2026 04:58
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from c4d49b9 to d7ee865 Compare July 12, 2026 08:54
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 02cb4e2 to 7cb9533 Compare July 12, 2026 08:54
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from d7ee865 to 59c8c85 Compare July 12, 2026 09:05
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 4bf71a5 to 0946378 Compare July 12, 2026 09:11
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch 2 times, most recently from 0e1b672 to b697469 Compare July 13, 2026 15:52
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 24c93b9 to ee1e8fd Compare July 13, 2026 17:29
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 8ea5a53 to 32efa63 Compare July 13, 2026 18:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from ee1e8fd to 31ebbda Compare July 13, 2026 18:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 32efa63 to e4fa818 Compare July 13, 2026 18:35
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 3bd8775 to 841ca28 Compare July 13, 2026 20:27
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from e4fa818 to 119c3a7 Compare July 13, 2026 20:27
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 841ca28 to 99291ad Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 119c3a7 to 95c5ca5 Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 99291ad to 260558c Compare July 13, 2026 22:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 95c5ca5 to 138681f Compare July 13, 2026 22:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 260558c to f6dfed1 Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch 2 times, most recently from 15bbbc2 to f16b507 Compare July 13, 2026 23:08
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 50cf30c to a36d53c Compare July 14, 2026 00:03
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from f16b507 to 57ef434 Compare July 14, 2026 00:03
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 57ef434 to a24f174 Compare July 14, 2026 03:20
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from a36d53c to 23fae65 Compare July 14, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant